Skip to content

feat: Add is_quarto_project criterion #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2023
Merged

feat: Add is_quarto_project criterion #92

merged 1 commit into from
Nov 5, 2023

Conversation

@olivroy
Copy link
Contributor

@olivroy olivroy commented Aug 29, 2023 •
edited
Loading

Fix #91
This PR also fixes some warnings with mockr.

Note that I was not able to load with load_all() on Windows

<error/rlang_error>
Error in `pkgload::load_all()`:
! Namespace for rprojroot can't already exist.
---
Backtrace:
    ▆
 1. └─pkgload::load_all()
 2.   └─pkgload:::create_ns_env(path)
 3.     └─cli::cli_abort(...)
 4.       └─rlang::abort(...)

Edit: I also forgot to create this PR from a branch..

Reference: https://quarto.org/docs/projects/quarto-projects.html

@krlmlr krlmlr mentioned this pull request Aug 30, 2023
Merged
@krlmlr
Copy link
Member

krlmlr commented Aug 30, 2023

My last action probably messed up your local clone, fix with git fetch && git rebase .

@krlmlr krlmlr changed the title Add quarto criterion feat: Add is_quarto_project criterion Aug 30, 2023
@olivroy
Copy link
Contributor Author

olivroy commented Aug 30, 2023

It is fine. Does the implementation look ok to you?

@krlmlr
Copy link
Member

krlmlr commented Sep 1, 2023

Thanks, looks good! I'll merge the next time I work on this package.

@aviator-app
Copy link
Contributor

aviator-app bot commented Nov 5, 2023 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@aviator-app aviator-app bot added the blocked label Nov 5, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Nov 5, 2023

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Remove the blocked label to re-queue.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

@krlmlr krlmlr removed the blocked label Nov 5, 2023
@aviator-app aviator-app bot merged commit a764d58 into r-lib:main Nov 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FR: Add Quarto criterion

2 participants

@olivroy @krlmlr